Update fibonacci_sequence_recursion.py #1268
Closed
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed Missing return statement.
cclauss
reviewed
Oct 3, 2019
| return n | ||
| else: | ||
| (recur_fibo(n-1) + recur_fibo(n-2)) | ||
| return recur_fibo(n-1) + recur_fibo(n-2) |
There was a problem hiding this comment.
return n if n <= 1 else recur_fibo(n-1) + recur_fibo(n-2)
cclauss
reviewed
Oct 3, 2019
| # Fibonacci Sequence Using Recursion | ||
|
|
||
| def recur_fibo(n): | ||
| if n <= 1: |
There was a problem hiding this comment.
Please add this doctest:
def recur_fibo(n):
"""
>>> [recur_fibo(i) for i in range(12)]
[0, 1, 1, 2, 3, 5, 8, 13, 21, 34, 55, 89]
"""
return n if n <= 1 else recur_fibo(n-1) + recur_fibo(n-2)
cclauss
reviewed
Oct 3, 2019
| (recur_fibo(n-1) + recur_fibo(n-2)) | ||
| return n if n <= 1 else recur_fibo(n-1) + recur_fibo(n-2) | ||
|
|
||
| def isPositiveInteger(limit): |
There was a problem hiding this comment.
This isPositiveInteger() function is too simple to be useful. Please removed it and do the test inline.
|
I just lost the forked-version hence cannot change (New GitHub user mistakes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Missing
returnstatement.